Request 3153 (superseded)

Overview

Request 3153 (superseded)

New release

Created by mollekopf almost 2 years ago
In state superseded
Supersedes 3152
Superseded by 3154
Open review for Admin
Open review for vanmeeuwen
Open review for mollekopf
Open review for kolab-developers

Submit pykolab-python3

Submit package Kolab:16:Testing / pykolab-python3 to package Kolab:16 / pykolab-python3

pykolab-0.9.0.tar.gz/wallace/__init__.py Changed

@@ -389,25 +389,22 @@
                     time.sleep(0.5)
 
                 pair = s.accept()
-                log.debug(
-                    _l("Accepted connection %r with address %r") % (
-                        pair if pair is not None else (None, None)
-                    ),
-                    level=8
-                )
 
                 if pair is not None:
-                    self.current_connections += 1
                     connection, address = pair
-
-                    log.debug(_l("Creating SMTPChannel for accepted message"), level=8)
+                    log.debug(
+                        _l("Accepted connection %r with address %r") % (
+                            connection, address 
+                        ),
+                        level=8
+                    )
 
                     def callback(filename):
                         self.pool.apply_async(pickup_message, (filename, (self.modules)))
-                        self.current_connections -= 1
 
-                    channel = WallaceSMTPChannel(connection, address, callback)
-                    channel.loop()
+                    self.current_connections += 1
+                    WallaceSMTPChannel(connection, address, callback).loop()
+                    self.current_connections -= 1
                 else:
                     log.error(_l("Socket accepted, but (conn, address) tuple is None."))

Build Results
RPM Lint

Refresh

Comments for request 3153 0

Request History

mollekopf created request almost 2 years ago

New release

mollekopf superseded request almost 2 years ago

superseded by 3154