Request 2507 (accepted)

Overview

Request 2507 (accepted)

Check in 1.4-rc1.133

Created by vanmeeuwen over 5 years ago
In state accepted

Submit roundcubemail

Submit package Kolab:Winterfell / roundcubemail to package Kolab:16 / roundcubemail

roundcubemail.spec Changed

@@ -49,14 +49,14 @@
 %global tmpdir /var/lib/roundcubemail
 
 %global rc_version 1.4
-%global rc_rel_suffix rc1.127
+%global rc_rel_suffix rc1.133
 %global dot_rel_suffix %{?rc_rel_suffix:.%{rc_rel_suffix}}
 %global dash_rel_suffix %{?rc_rel_suffix:-%{rc_rel_suffix}}
 
 Name:           roundcubemail
 Version:        1.4
 
-Release:        238%{?dot_rel_suffix}%{?dist}
+Release:        240%{?dot_rel_suffix}%{?dist}
 
 Summary:        Round Cube Webmail is a browser-based multilingual IMAP client
 
@@ -3438,8 +3438,8 @@
 %defattr(-,root,root,-)
 
 %changelog
-* Mon May 13 2019 Jeroen van Meeuwen (Kolab Systems) <vanmeeuwen@kolabsys.com> - 1.4-238.rc1.127
-- Check in 127 revisions ahead of the upstream rc1 release
+* Wed May 15 2019 Jeroen van Meeuwen (Kolab Systems) <vanmeeuwen@kolabsys.com> - 1.4-240.rc1.133
+- Check in 133 revisions ahead of the upstream 1.4-rc1 release
 
 * Mon Apr 15 2019 Jeroen van Meeuwen (Kolab Systems) <vanmeeuwen@kolabsys.com> - 1.4-236.rc1.65
 - Check in 65 revisions ahead of the upstream rc1 release

debian.changelog Changed

roundcubemail-1.4-rc1.127.tar.gz/CHANGELOG -> roundcubemail-1.4-rc1.133.tar.gz/CHANGELOG Changed

@@ -18,6 +18,8 @@
 - Elastic: Various internal refactorings
 - Elastic: Fix issue with absolute positioned mail content (#6739)
 - Elastic: Fix bug where some menu actions could cause a browser popup warning
+- Elastic: Fix handling mailto: URL parameters in contact menu (#6751)
+- Elastic: Fix keyboard navigation in some menus, e.g. the contact menu
 - Larry: Fix regression where menu actions didn't work with keyboard (#6740)
 - Password: Added ldap_exop driver (#4992)
 - Managesieve: Fix bug where global includes were requested for vacation (#6716)
@@ -26,6 +28,7 @@
 - Enigma: Fix bug where revoked users/keys were not greyed out in key info
 - Enigma: Fix error message when trying to encrypt with a revoked key (#6607)
 - Enigma: Fix "decryption oracle" bug [CVE-2019-10740] (#6638)
+- Fix invalid path to blocked.gif when using assets_path setting (#6752)
 - Fix so advanced search dialog is not automatically displayed on searchonly addressbooks (#6679)
 - Fix so an error is logged when more than one attachment plugin has been enabled, initialize the first one (#6735)
 - Fix bug where flag change could have been passed to a preview frame when not expected

roundcubemail-1.4-rc1.127.tar.gz/program/lib/Roundcube/rcube_charset.php -> roundcubemail-1.4-rc1.133.tar.gz/program/lib/Roundcube/rcube_charset.php Changed

roundcubemail-1.4-rc1.127.tar.gz/program/steps/mail/compose.inc -> roundcubemail-1.4-rc1.133.tar.gz/program/steps/mail/compose.inc Changed

roundcubemail-1.4-rc1.127.tar.gz/program/steps/mail/func.inc -> roundcubemail-1.4-rc1.133.tar.gz/program/steps/mail/func.inc Changed

roundcubemail-1.4-rc1.127.tar.gz/program/steps/mail/get.inc -> roundcubemail-1.4-rc1.133.tar.gz/program/steps/mail/get.inc Changed

roundcubemail-1.4-rc1.127.tar.gz/skins/elastic/styles/colors.less -> roundcubemail-1.4-rc1.133.tar.gz/skins/elastic/styles/colors.less Changed

roundcubemail-1.4-rc1.127.tar.gz/skins/elastic/styles/styles.less -> roundcubemail-1.4-rc1.133.tar.gz/skins/elastic/styles/styles.less Changed

roundcubemail-1.4-rc1.127.tar.gz/skins/elastic/styles/widgets/common.less -> roundcubemail-1.4-rc1.133.tar.gz/skins/elastic/styles/widgets/common.less Changed

roundcubemail-1.4-rc1.127.tar.gz/skins/elastic/styles/widgets/messages.less -> roundcubemail-1.4-rc1.133.tar.gz/skins/elastic/styles/widgets/messages.less Changed

@@ -15,8 +15,8 @@
 
 .ui.alert {
     margin: 0;
+    margin-bottom: .2rem;
     opacity: .95;
-    float: left;
     width: 100%;
     padding: .75em;
     color: @color-message;
@@ -27,16 +27,9 @@
 
     @media screen and (max-width: @screen-width-xs) {
         border: 0;
-        border-radius: 0;
         min-height: 4.2rem;
     }
 
-    @media screen and (min-width: (@screen-width-xs + 1px)) {
-        &:not(:last-child) {
-            margin-bottom: .2rem;
-        }
-    }
-
     span {
         margin: auto 0;
     }
@@ -127,19 +120,11 @@
     &.boxconfirmation,
     &.boxinformation,
     &.boxwarning {
-        float: none;
-        border-radius: 0;
-        border: none;
         padding: .5em;
-        margin-top: 0; // this can be a <p> element, reset default margin
 
         i.icon {
             font-size: 1.5em !important;
         }
-
-        &:not(:last-child) {
-            margin-bottom: .2rem;
-        }
     }
 
     &.boxerror {
@@ -184,10 +169,14 @@
     }
 
     div {
-        border-color: transparent;
+        border-radius: .25rem;
         background-color: @color-message;
         color: #fff;
 
+        @media screen and (max-width: @screen-width-xs) {
+            margin: 0;
+        }
+
         &.voice {
             position: absolute;
             top: -1000px;
@@ -200,6 +189,14 @@
         & > i.icon:before {
             color: #fff;
         }
+
+        &:last-child {
+            margin-bottom: 0;
+        }
+
+        @media screen and (max-width: @screen-width-xs) {
+            margin: 0;
+        }
     }
 
     .loading {

roundcubemail-1.4-rc1.127.tar.gz/skins/elastic/ui.js -> roundcubemail-1.4-rc1.133.tar.gz/skins/elastic/ui.js Changed

@@ -2474,6 +2474,7 @@
 
                 if (!$(target).data('popup')) {
                     $(target).data({
+                        event: rcube_event.is_keyboard(p.originalEvent) ? 'key' : 'mouse',
                         popup: p.name,
                         'popup-pos': pos,
                         'popup-trigger': 'manual'
@@ -2878,7 +2879,7 @@
     /**
      * Mailto menu
      */
-    function mailtomenu(obj, button, event)
+    function mailtomenu(obj, button, event, onclick)
     {
         var mailto = $(button).attr('href').replace(/^mailto:/, '');
 
@@ -2886,9 +2887,11 @@
             return true; // let the browser handle this
         }
 
+        // disable all menu actions
+        obj.find('a').off('click').removeClass('active');
+
         if (rcmail.env.has_writeable_addressbook) {
-            $('.addressbook', obj).addClass('active')
-                .off('click').on('click', function(e) {
+            $('.addressbook', obj).addClass('active').on('click', function(e) {
                     var i, contact = mailto,
                         txt = $(button).filter('.rcmContactAddress').text();
 
@@ -2903,11 +2906,20 @@
                 });
         }
 
-        $('.compose', obj).off('click').on('click', function(e) {
-            rcmail.command('compose', mailto, this, e.originalEvent);
+        $('.compose', obj).addClass('active').on('click', function(e) {
+            // Execute the original onclick handler to support mailto URL arguments (#6751)
+            if (onclick) {
+                button.onclick = onclick;
+                // use the second argument to tell our handler to not display the menu again
+                $(button).trigger('click', [true]);
+                button.onclick = null;
+            }
+            else {
+                rcmail.command('compose', mailto, this, e.originalEvent);
+            }
         });
 
-        return rcmail.command('menu-open', {menu: 'mailto-menu', link: button}, button, event);
+        return rcmail.command('menu-open', {menu: 'mailto-menu', link: button}, button, event.originalEvent);
     };
 
     /**
@@ -2915,8 +2927,11 @@
      */
     function mailtomenu_append(item)
     {
-        $(item).attr('onclick', '').on('click', function(e) {
-            return mailtomenu($('#mailto-menu'), item, e);
+        // Remember the original onclick handler and display the menu instead
+        var onclick = item.onclick;
+        item.onclick = null;
+        $(item).on('click', function(e, menu) {
+            return menu || mailtomenu($('#mailto-menu'), item, e, onclick);
         });
     };

roundcubemail.dsc Changed

Build Results
RPM Lint

Refresh

Comments for request 2507 0

Request History

vanmeeuwen created request over 5 years ago

Check in 1.4-rc1.133

vanmeeuwen accepted review over 5 years ago

vanmeeuwen approved review over 5 years ago

vanmeeuwen accepted request over 5 years ago