Request 2518 (accepted)

Overview

Request 2518 (accepted)

Fix for context menu

Created by vanmeeuwen over 5 years ago
In state accepted

Submit roundcubemail

Submit package Kolab:Winterfell / roundcubemail to package Kolab:16 / roundcubemail

roundcubemail.spec Changed

@@ -56,7 +56,7 @@
 Name:           roundcubemail
 Version:        1.4
 
-Release:        240%{?dot_rel_suffix}%{?dist}
+Release:        242%{?dot_rel_suffix}%{?dist}
 
 Summary:        Round Cube Webmail is a browser-based multilingual IMAP client
 
@@ -79,6 +79,8 @@
 Patch201:       default-configuration.patch
 Patch202:       roundcubemail-1.4-beta86-plugin-enigma-homedir.patch
 
+Patch0001:      roundcubemail-1.4.rc1.133-add-in_selection.patch
+
 BuildArch:      noarch
 BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root%(%{__id_u} -n)
 
@@ -1525,6 +1527,8 @@
 %patch202 -p1
 %endif
 
+%patch0001 -p1
+
 # Remove the results of patching when there's an incidental offset
 find . -type f -name "*.orig" | while read file; do
     rm -rvf ${file}
@@ -3438,6 +3442,9 @@
 %defattr(-,root,root,-)
 
 %changelog
+* Mon May 20 2019 Jeroen van Meeuwen (Kolab Systems) <vanmeeuwen@kolabsys.com> - 1.4-242.rc1.133
+- Fix for context menu
+
 * Wed May 15 2019 Jeroen van Meeuwen (Kolab Systems) <vanmeeuwen@kolabsys.com> - 1.4-240.rc1.133
 - Check in 133 revisions ahead of the upstream 1.4-rc1 release

roundcubemail-1.4.rc1.133-add-in_selection.patch Added

@@ -0,0 +1,37 @@
+commit d646a10217ad99bda44c2c5930e15c4d71481c78
+Author: Aleksander Machniak <alec@alec.pl>
+Date:   Mon May 20 11:33:14 2019 +0200
+
+    Add in_selection() to rcube_treelist_widget
+    
+    So code working on all lists doesn't have to check widget type
+    to work with selection.
+
+diff --git a/program/js/treelist.js b/program/js/treelist.js
+index 04e36ae22..96610a14c 100644
+--- a/program/js/treelist.js
++++ b/program/js/treelist.js
+@@ -96,6 +96,7 @@ function rcube_treelist_widget(node, p)
+   this.get_item = get_item;
+   this.get_node = get_node;
+   this.get_selection = get_selection;
++  this.in_selection = in_selection;
+   this.get_next = get_next;
+   this.get_prev = get_prev;
+   this.get_single_selection = get_selection;
+@@ -295,6 +296,15 @@ function rcube_treelist_widget(node, p)
+     return selection;
+   }
+ 
++  /**
++   * Check if given id is selected
++   * This is for consistency with rcube_list_widget
++   */
++  function in_selection(id)
++  {
++    return selection == id;
++  }
++
+   /**
+    * Return the DOM element of the list item with the given ID
+    */

debian.changelog Changed

debian.series Changed

roundcubemail.dsc Changed

Build Results
RPM Lint

Refresh

Comments for request 2518 0

Request History

vanmeeuwen created request over 5 years ago

Fix for context menu

vanmeeuwen accepted review over 5 years ago

vanmeeuwen approved review over 5 years ago

vanmeeuwen accepted request over 5 years ago