Request 2782 (accepted)

Overview

Request 2782 (accepted)

New upstream release

Created by mollekopf over 3 years ago
In state accepted
Open review for Admin

Submit kolab-syncroton

Submit package home:mollek...:Winterfell / kolab-syncroton to package Kolab:Winterfell / kolab-syncroton

kolab-syncroton.spec Changed

debian.changelog Changed

kolab-syncroton-2.3.18.tar.gz/lib/ext/Syncroton/Command/Sync.php -> kolab-syncroton-2.3.19.tar.gz/lib/ext/Syncroton/Command/Sync.php Changed

@@ -830,6 +830,14 @@
                         
                         $commands->appendChild($add);
                         
+                        $newContentStates[] = new Syncroton_Model_Content(array(
+                            'device_id'        => $this->_device,
+                            'folder_id'        => $collectionData->folder,
+                            'contentid'        => $serverId,
+                            'creation_time'    => $this->_syncTimeStamp,
+                            'creation_synckey' => $collectionData->syncState->counter + 1
+                        ));
+
                         $collectionChanges++;
                     } catch (Syncroton_Exception_MemoryExhausted $seme) {
                         // continue to next entry, as there is not enough memory left for the current entry
@@ -844,16 +852,11 @@
                             $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " unable to convert entry to xml: " . $e->getMessage());
                         if ($this->_logger instanceof Zend_Log)
                             $this->_logger->debug(__METHOD__ . '::' . __LINE__ . " unable to convert entry to xml: " . $e->getTraceAsString());
+                        // We bump collectionChanges anyways to make sure the windowSize still applies.
+                        $collectionChanges++;
                     }
                     
                     // mark as sent to the client, even the conversion to xml might have failed 
-                    $newContentStates[] = new Syncroton_Model_Content(array(
-                        'device_id'        => $this->_device,
-                        'folder_id'        => $collectionData->folder,
-                        'contentid'        => $serverId,
-                        'creation_time'    => $this->_syncTimeStamp,
-                        'creation_synckey' => $collectionData->syncState->counter + 1
-                    ));
                     unset($serverModifications['added'][$id]);
                 }
 
@@ -890,6 +893,8 @@
                     } catch (Exception $e) {
                         if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " unable to convert entry to xml: " . $e->getMessage());
+                        // We bump collectionChanges anyways to make sure the windowSize still applies.
+                        $collectionChanges++;
                     }
 
                     unset($serverModifications['changed'][$id]);    
@@ -915,6 +920,8 @@
                     } catch (Exception $e) {
                         if ($this->_logger instanceof Zend_Log) 
                             $this->_logger->warn(__METHOD__ . '::' . __LINE__ . " unable to convert entry to xml: " . $e->getMessage());
+                        // We bump collectionChanges anyways to make sure the windowSize still applies.
+                        $collectionChanges++;
                     }
                     
                     unset($serverModifications['deleted'][$id]);

kolab-syncroton-2.3.18.tar.gz/lib/kolab_sync.php -> kolab-syncroton-2.3.19.tar.gz/lib/kolab_sync.php Changed

kolab-syncroton-2.3.18.tar.gz/lib/kolab_sync_backend.php -> kolab-syncroton-2.3.19.tar.gz/lib/kolab_sync_backend.php Changed

kolab-syncroton-2.3.18.tar.gz/lib/kolab_sync_backend_state.php -> kolab-syncroton-2.3.19.tar.gz/lib/kolab_sync_backend_state.php Changed

kolab-syncroton.dsc Changed

Build Results
RPM Lint

Refresh

Comments for request 2782 0

Request History

mollekopf created request over 3 years ago

New upstream release

mollekopf accepted review over 3 years ago

mollekopf accepted request over 3 years ago