Request 3207 (accepted)

You're not reviewing the full diff of request 3207 , but the diff to the superseded request 3204 (Show full diff)

Overview

Request 3207 (accepted)

New release

Created by mollekopf over 1 year ago
In state accepted
Supersedes 3204
Open review for Admin
Open review for vanmeeuwen
Open review for mollekopf
Open review for kolab-developers

Submit iRony

Submit package Kolab:16:Testing / iRony to package Kolab:16 / iRony

iRony.spec Changed

debian.changelog Changed

iRony-0.4.8.tar.gz/lib/Kolab/CalDAV/CalendarBackend.php Changed

iRony-0.4.8.tar.gz/lib/Kolab/CardDAV/LDAPDirectory.php Changed

@@ -62,7 +62,7 @@
         $this->addressBookInfo = array(
             'id' => self::DIRECTORY_NAME,
             'uri' => self::DIRECTORY_NAME,
-            '{DAV:}displayname' => !empty($config'name') ? $config'name' : "LDAP Directory",
+            '{DAV:}displayname' => $config'name' ?: "LDAP Directory",
             '{urn:ietf:params:xml:ns:carddav}supported-address-data' => new CardDAV\Xml\Property\SupportedAddressData(),
             'principaluri' => $principalUri,
         );
@@ -85,12 +85,12 @@
 
     private function connect()
     {
-        if (!isset($this->ldap)) {
-            $this->ldap = new rcube_ldap($this->config, $this->config'debug');
-            $this->ldap->set_pagesize(!empty($this->config'sizelimit') ? $this->config'sizelimit' : 10000);
-        }
+      if (!isset($this->ldap)) {
+        $this->ldap = new rcube_ldap($this->config, $this->config'debug');
+        $this->ldap->set_pagesize($this->config'sizelimit' ?: 10000);
+      }
 
-        return $this->ldap->ready ? $this->ldap : null;
+      return $this->ldap->ready ? $this->ldap : null;
     }
 
     /**
@@ -199,7 +199,7 @@
         $children = array();
 
         // return cached index
-        if (!$this->query && empty($this->config'searchonly') && $this->cache && ($cached_index = $this->cache->get('index'))) {
+        if (!$this->query && !$this->config'searchonly' && $this->cache && ($cached_index = $this->cache->get('index'))) {
             foreach ($cached_index as $uid => $c) {
                 $obj = array(
                     'id'   => $uid,
@@ -214,7 +214,7 @@
         }
 
         // query LDAP if we have a search query or listing is allowed
-        if (($this->query || empty($this->config'searchonly')) && ($ldap = $this->connect())) {
+        if (($this->query || !$this->config'searchonly') && ($ldap = $this->connect())) {
             // set pagesize from query limit attribute
             if ($this->query && $this->query->limit) {
                 $this->ldap->set_pagesize(intval($this->query->limit));

iRony.dsc Changed

Build Results
RPM Lint

Refresh

Comments for request 3207 0

Request History

mollekopf created request over 1 year ago

New release

mollekopf accepted request over 1 year ago