Request 3204 (superseded)

iRony.spec Changed

debian.changelog Changed

iRony-0.4.8.tar.gz/composer.json Changed

iRony-0.4.8.tar.gz/composer.json-dist Changed

iRony-0.4.8.tar.gz/lib/Kolab/CalDAV/CalendarBackend.php Changed

@@ -972,8 +972,7 @@
      * Checks if specified message part is a vcalendar data
      *
      * @param rcube_message_part Part object
-     *
-     * @return bool True if part is of type vcard
+     * @return boolean True if part is of type vcard
      */
     protected static function part_is_itip($part)
     {
@@ -1026,7 +1025,6 @@
      * Parse the given iCal string into a hash array kolab_format_event can handle
      *
      * @param string iCal data block
-     *
      * @return array Hash array with event properties or null on failure
      */
     private function parse_calendar_data($calendarData, $uid)
@@ -1113,8 +1111,7 @@
     /**
      * Provide basic query for kolab_storage_folder::select()
      *
-     * @param bool Filter for inbox events (i.e. status=NEEDS-ACTION)
-     *
+     * @param boolean Filter for inbox events (i.e. status=NEEDS-ACTION)
      * @return array  List of query parameters for kolab_storage_folder::select()
      */
     private function _event_filter_query($inbox = false)
@@ -1144,10 +1141,9 @@
     /**
      * Check the given event if it matches the filter
      *
-     * @param array Hash array with event properties
-     * @param bool  Filter for inbox events (i.e. status=NEEDS-ACTION)
-     *
-     * @return bool True if matches, false if not
+     * @param array    Hash array with event properties
+     * @param boolean  Filter for inbox events (i.e. status=NEEDS-ACTION)
+     * @return boolean True if matches, false if not
      */
     private function _event_filter_compare($event, $inbox = false)
     {
@@ -1157,14 +1153,14 @@
             $user_emails = $this->get_user_emails();
         }
 
-        if (!empty($event'attendees') && is_array($event'attendees')) {
+        if (is_array($event'attendees')) {
             foreach ($event'attendees' as $attendee) {
                 if (in_array($attendee'email', $user_emails)) {
                     $status = !empty($attendee'status') ? $attendee'status' : null;
                     if ($status == 'DECLINED') {
                         return false;
                     }
-                    if ($inbox && $status == 'NEEDS-ACTION') {
+                    else if ($inbox && $status == 'NEEDS-ACTION') {
                         return true;
                     }
                 }
@@ -1178,7 +1174,6 @@
      * Generate an Etag string from the given event data
      *
      * @param array Hash array with event properties from libkolab
-     *
      * @return string Etag string
      */
     private static function _get_etag($event)

iRony-0.4.8.tar.gz/lib/Kolab/CardDAV/ContactsBackend.php Changed

@@ -681,12 +681,12 @@
         $vc = new VObject\Component\VCard();
         $vc->VERSION = '3.0';  // always set to 3.0 and let Sabre/DAV convert to 4.0 if necessary
         $vc->PRODID = '-//Kolab//iRony DAV Server ' . KOLAB_DAV_VERSION . '//Sabre//Sabre VObject ' . VObject\Version::VERSION . '//EN';
-        $vc->UID = $contact'uid';
 
+        $vc->add('UID', $contact'uid');
         $vc->add('FN', $contact'name');
 
         // distlists are KIND:group
-        if (isset($contact'_type') && $contact'_type' == 'distribution-list') {
+        if ($contact'_type' == 'distribution-list') {
             // group cards are actually vcard version 4
             if (!$this->is_apple()) {
                 $vc->version = '4.0';
@@ -709,18 +709,10 @@
                 $vc->add($prop_prefix . 'MEMBER', $value);
             }
         }
-        else {
-            $allname = ($contact'surname' ?? '')
-                . ($contact'firstname' ?? '')
-                . ($contact'middlename' ?? '')
-                . ($contact'prefix' ?? '')
-                . ($contact'suffix' ?? '');
-
-            if ($allname != '') {
-                $n = $vc->create('N');
-                $n->setParts(array($contact'surname' ?? '', $contact'firstname' ?? '', $contact'middlename' ?? '', $contact'prefix' ?? '', $contact'suffix' ?? ''));
-                $vc->add($n);
-            }
+        else if ($contact'surname' . $contact'firstname' . $contact'middlename' . $contact'prefix' . $contact'suffix' != '') {
+            $n = $vc->create('N');
+            $n->setParts(array(strval($contact'surname'), strval($contact'firstname'), strval($contact'middlename'), strval($contact'prefix'), strval($contact'suffix')));
+            $vc->add($n);
         }
 
         if (!empty($contact'nickname'))
@@ -759,48 +751,36 @@
             }
         }
 
-        if (!empty($contact'email')) {
-            foreach ((array)$contact'email' as $email) {
-                $types = array('INTERNET');
-                if (!empty($email'type'))
-                    $types = array_merge($types, explode(',', strtoupper($email'type')));
-                $vc->add('EMAIL', $email'address', array('type' => $types));
-            }
+        foreach ((array)$contact'email' as $email) {
+            $types = array('INTERNET');
+            if (!empty($email'type'))
+                $types = array_merge($types, explode(',', strtoupper($email'type')));
+            $vc->add('EMAIL', $email'address', array('type' => $types));
         }
 
-        if (!empty($contact'phone')) {
-            foreach ((array)$contact'phone' as $phone) {
-                $type = $this->phonetypes$phone'type' ?? $phone'type';
-                $params = !empty($type) ? array('type' => explode(',', strtoupper($type))) : array();
-                $vc->add('TEL', $phone'number', $params);
-            }
+        foreach ((array)$contact'phone' as $phone) {
+            $type = $this->phonetypes$phone'type' ?: $phone'type';
+            $params = !empty($type) ? array('type' => explode(',', strtoupper($type))) : array();
+            $vc->add('TEL', $phone'number', $params);
         }
 
-        if (!empty($contact'website')) {
-            if (!empty($contact'website')) {
-                foreach ((array)$contact'website' as $website) {
-                    $params = !empty($website'type') ? array('type' => explode(',', strtoupper($website'type'))) : array();
-                    $vc->add('URL', $website'url', $params);
-                }
-            }
+        foreach ((array)$contact'website' as $website) {
+            $params = !empty($website'type') ? array('type' => explode(',', strtoupper($website'type'))) : array();
+            $vc->add('URL', $website'url', $params);
         }
 
-        if (!empty($contact'im')) {
-            $improtocolmap = array_flip($this->improtocols);
-            foreach ((array)$contact'im' as $im) {
-                list($prot, $val) = explode(':', $im, 2);
-                if ($val && !$v4) $vc->add('x-' . ($improtocolmap$prot ?: $prot), $val);
-                else              $vc->add('IMPP', $im);
-            }
+        $improtocolmap = array_flip($this->improtocols);
+        foreach ((array)$contact'im' as $im) {
+            list($prot, $val) = explode(':', $im, 2);
+            if ($val && !$v4) $vc->add('x-' . ($improtocolmap$prot ?: $prot), $val);
+            else              $vc->add('IMPP', $im);
         }
 
-        if (!empty($contact'address')) {
-            foreach ((array)$contact'address' as $adr) {
-                $params = !empty($adr'type') ? array('type' => strtoupper($adr'type')) : array();
-                $vadr = $vc->create('ADR', null, $params);
-                $vadr->setParts(array('','', $adr'street', $adr'locality', $adr'region', $adr'code', $adr'country'));
-                $vc->add($vadr);
-            }
+        foreach ((array)$contact'address' as $adr) {
+            $params = !empty($adr'type') ? array('type' => strtoupper($adr'type')) : array();
+            $vadr = $vc->create('ADR', null, $params);
+            $vadr->setParts(array('','', $adr'street', $adr'locality', $adr'region', $adr'code', $adr'country'));
+            $vc->add($vadr);
         }
 
         if (!empty($contact'notes'))
@@ -841,7 +821,7 @@
             $vc->add('FBURL', $contact'freebusyurl');
         }
 
-        if (!empty($contact'lang') && is_array($contact'lang')) {
+        if (is_array($contact'lang')) {
             foreach ($contact'lang' as $value) {
                 $vc->add('LANG', $value);
             }
@@ -854,10 +834,8 @@
         }
 
         // add custom properties
-        if (!empty($contact'x-custom')) {
-            foreach ((array)$contact'x-custom' as $prop) {
-                $vc->add($prop0, $prop1);
-            }
+        foreach ((array)$contact'x-custom' as $prop) {
+            $vc->add($prop0, $prop1);
         }
 
         // send some known fields as itemN.X-AB* for Apple clients
@@ -1087,9 +1065,8 @@
             }
         }
 
-        if (isset($contact'im') && is_array($contact'im')) {
+        if (is_array($contact'im'))
             $contact'im' = array_unique($contact'im');
-        }
 
         return $contact;
     }
@@ -1164,9 +1141,9 @@
     /**
      * Extract array values by a filter
      *
-     * @param array        $arr     Array to filter
-     * @param array|string $values  Array or comma separated list of values to keep
-     * @param bool         $inverse Invert key selection: remove the listed values
+     * @param array Array to filter
+     * @param keys Array or comma separated list of values to keep
+     * @param boolean Invert key selection: remove the listed values
      *
      * @return array The filtered array
      */
@@ -1176,15 +1153,15 @@
             $values = explode(',', $values);
         }
 
+        // explode single, comma-separated value
+        if (count($arr) == 1 && strpos($arr0, ',')) {
+            $arr = explode(',', $arr0);
+        }
+
         $result = array();
         $keep   = array_flip((array)$values);
 
         if (!empty($arr)) {
-            // explode single, comma-separated value
-            if (count($arr) == 1 && strpos($arr0, ',')) {
-                $arr = explode(',', $arr0);
-            }
-
             foreach ($arr as $key => $val) {
                 if ($inverse != isset($keepstrtolower($val))) {
                     $result$key = $val;

iRony-0.4.8.tar.gz/public_html/index.php Changed

iRony-0.4.8.tar.gz/test/Unit/CardDAV/ContactsBackend.php Changed

@@ -1,10 +1,14 @@
 <?php
 
 use Kolab\CardDAV\ContactsBackend;
-use PHPUnit\Framework\TestCase;
 
-class ContactsBackendTest extends TestCase
+class ContactsBackendTest extends PHPUnit_Framework_TestCase
 {
+    function setUp()
+    {
+    }
+
+
     /**
      * Test vCard PHOTO (T1082)
      */
@@ -19,7 +23,7 @@
 
         $vcard = $backend->to_vcard($contact);
 
-        $this->assertMatchesRegularExpression('/PHOTO;ENCODING=b;TYPE=GIF:R0l/', $vcard);
+        $this->assertRegexp('/PHOTO;ENCODING=b;TYPE=GIF:R0l/', $vcard);
     }
 
     /**
@@ -33,7 +37,7 @@
         $vcard   = "BEGIN:VCARD\nVERSION:$version\nN:Thompson;Default;;;\nUID:1\n$input\nEND:VCARD";
         $contact = $backend->parse_vcard($vcard);
 
-        $this->assertSame($output, $contact'photo' ?? null);
+        $this->assertSame($output, $contact'photo');
     }
 
     function data_T2043()
@@ -60,7 +64,7 @@
         $vcard   = "BEGIN:VCARD\nVERSION:4.0\nN:Thompson;Default;;;\nUID:1\n$input\nEND:VCARD";
         $contact = $backend->parse_vcard($vcard);
 
-        if ($result = ($contact$key ?? null)) {
+        if ($result = $contact$key) {
             $result = $result->format('Ymd');
         }
 
@@ -80,39 +84,4 @@
             array("ANNIVERSARY;VALUE=text:circa 1800", null, 'anniversary'),
         );
     }
-
-    /**
-     * Test basic vCard generation
-     */
-    function test_to_vcard()
-    {
-        $backend = new ContactsBackend();
-        $contact = array(
-            'uid'   => '123',
-            'name'  => 'Test',
-            'phone' => array(
-                array (
-                    'number' => '+48',
-                    'type' => 'home',
-                ),
-            ),
-        );
-
-        $vcard = $backend->to_vcard($contact);
-
-        $prodid = '-//Kolab//iRony DAV Server ' . KOLAB_DAV_VERSION . '//Sabre//Sabre VObject ' . Sabre\VObject\Version::VERSION . '//EN';
-        $expected = <<<EOF
-            BEGIN:VCARD\r
-            VERSION:3.0\r
-            PRODID:$prodid\r
-            UID:123\r
-            FN:Test\r
-            TEL;TYPE=HOME:+48\r
-            END:VCARD\r
-            EOF;
-
-        $this->assertSame(trim($expected), trim($vcard));
-
-        // TODO: Test all contact/group properties
-    }
 }

iRony.dsc Changed

Overview

Request 3204 (superseded)

Request History