Request 3208 (superseded)

pykolab.spec Changed

@@ -55,8 +55,8 @@
 
 Summary:            Kolab Groupware Solution
 Name:               pykolab
-Version: 0.9.0.7
-Release:            2%{?dist}
+Version: 0.9.0.2
+Release:            1%{?dist}
 License:            GPLv3+
 Group:              Applications/System
 URL:                http://kolab.org/
@@ -64,8 +64,6 @@
 Source0:            pykolab-%{upstream_version}.tar.gz
 Source1:            pykolab.logrotate
 
-Patch0001:          0001-T8337-Fix-UnicodeDecodeError-in-wallace.patch
-
 BuildRoot:          %{_tmppath}/%{name}-%{version}-%{release}-root
 BuildArch:          noarch
 
@@ -253,7 +251,6 @@
 
 %prep
 %setup -q -n %{name}-%{upstream_version}
-%patch0001 -p1
 
 %build
 autoreconf -v || automake --add-missing && autoreconf -v
@@ -620,9 +617,6 @@
 %attr(0700,%{kolab_user},%{kolab_group}) %dir %{_var}/spool/pykolab/wallace
 
 %changelog
-* Fri Sep 20 2022 Christoph Erhardt <kolab@sicherha.de> - 0.9.0.7-2
-- Fix `UnicodeDecodeError` in wallace
-
 * Tue Aug  2 2022 Christian Mollekopf <mollekopf@apheleia-it.ch> - 0.8.23-2
 - Python3 support on centos 8

0001-T8337-Fix-UnicodeDecodeError-in-wallace.patch Deleted

@@ -1,29 +0,0 @@
-From 0b38809701d43140840c8e83fc0b4c90ef272163 Mon Sep 17 00:00:00 2001
-Message-ID: <0b38809701d43140840c8e83fc0b4c90ef272163.1726868869.git.kolab@sicherha.de>
-From: Christoph Erhardt <kolab@sicherha.de>
-Date: Fri, 20 Sep 2024 23:42:37 +0200
-Subject: PATCH T8337: Fix `UnicodeDecodeError` in wallace
-
-Reviewers: mollekopf
-
-Differential Revision: https://git.kolab.org/D4959
----
- wallace/modules.py | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/wallace/modules.py b/wallace/modules.py
-index f774e6e..e4a4ab6 100644
---- a/wallace/modules.py
-+++ b/wallace/modules.py
-@@ -369,7 +369,7 @@ def cb_action_ACCEPT(module, filepath):
-     log.debug(_("Accepting message in: %r") %(filepath), level=8)
- 
-     # parse message headers
--    message = Parser().parse(open(filepath, 'r'), True)
-+    message = Parser().parse(open(filepath, 'r', encoding="utf8", errors="ignore"), True)
- 
-     messageid = message'message-id' if 'message-id' in message else None
-     sender = formataddr(x) for x in getaddresses(message.get_all('X-Kolab-From', ))
--- 
-2.46.1
-

debian.changelog Changed

debian.series Changed

pykolab-0.9.0.tar.gz/pykolab/auth/__init__.py Changed

pykolab-0.9.0.tar.gz/pykolab/auth/ldap/__init__.py Changed

@@ -124,7 +124,13 @@
             log.error(_l("Authentication cache failed: %r") % (errmsg))
 
         if base_dn is None:
-            base_dn = self._base_dn()
+            config_base_dn = self.config_get('base_dn')
+            ldap_base_dn = self._kolab_domain_root_dn(self.domain)
+
+            if ldap_base_dn is not None and not ldap_base_dn == config_base_dn:
+                base_dn = ldap_base_dn
+            else:
+                base_dn = config_base_dn
 
             try:
                 auth_cache.set_entry(self.domain, base_dn)
@@ -453,11 +459,18 @@
             return entry_id'dn'
 
         unique_attribute = self.config_get('unique_attribute')
+        config_base_dn = self.config_get('base_dn')
+        ldap_base_dn = self._kolab_domain_root_dn(self.domain)
+
+        if ldap_base_dn is not None and not ldap_base_dn == config_base_dn:
+            base_dn = ldap_base_dn
+        else:
+            base_dn = config_base_dn
 
         _filter = "(%s=%s)" % (unique_attribute, ldap.filter.escape_filter_chars(entry_id))
 
         _search = self.ldap.search_ext(
-            self._base_dn(),
+            base_dn,
             ldap.SCOPE_SUBTREE,
             _filter,
             'entrydn'
@@ -701,13 +714,19 @@
 
         _filter = "%s%s%s" % (__filter_prefix, _filter, __filter_suffix)
 
-        base_dn = self._base_dn()
-
-        log.debug(_l("Finding recipient with filter %r in %s") % (_filter, base_dn), level=8)
+        log.debug(_l("Finding recipient with filter %r") % (_filter), level=8)
 
         if len(_filter) <= 6:
             return None
 
+        config_base_dn = self.config_get('base_dn')
+        ldap_base_dn = self._kolab_domain_root_dn(self.domain)
+
+        if ldap_base_dn is not None and not ldap_base_dn == config_base_dn:
+            base_dn = ldap_base_dn
+        else:
+            base_dn = config_base_dn
+
         _results = self.ldap.search_s(
             base_dn,
             scope=ldap.SCOPE_SUBTREE,
@@ -771,13 +790,13 @@
 
         _filter = "%s%s%s" % (__filter_prefix, _filter, __filter_suffix)
 
+        log.debug(_l("Finding resource with filter %r") % (_filter), level=8)
+
         if len(_filter) <= 6:
             return None
 
         resource_base_dn = self._object_base_dn('resource')
 
-        log.debug(_l("Finding resource with filter %s in %s") % (_filter, resource_base_dn), level=8)
-
         _results = self.ldap.search_s(
             resource_base_dn,
             scope=ldap.SCOPE_SUBTREE,
@@ -1201,9 +1220,13 @@
 
         _filter = "(%s=%s)" % (attr, ldap.filter.escape_filter_chars(value))
 
-        base_dn = self._base_dn()
+        config_base_dn = self.config_get('base_dn')
+        ldap_base_dn = self._kolab_domain_root_dn(self.domain)
 
-        log.debug(_l("Finding entry %s in %s") % (_filter, base_dn), level=8)
+        if ldap_base_dn is not None and not ldap_base_dn == config_base_dn:
+            base_dn = ldap_base_dn
+        else:
+            base_dn = config_base_dn
 
         _results = self._search(
             base_dn,
@@ -1298,14 +1321,22 @@
 
         _filter = "(&%s(modifytimestamp>=%s))" % (_filter, modified_after)
 
+        log.debug(_l("Synchronization is using filter %r") % (_filter), level=8)
+
         if mode != 0:
             override_search = mode
         else:
-            override_search = None
+            override_search = False
 
-        base_dn = self._base_dn()
+        config_base_dn = self.config_get('base_dn')
+        ldap_base_dn = self._kolab_domain_root_dn(self.domain)
 
-        log.debug(_l("Synchronization is searching for %s in %s") % (_filter, base_dn), level=8)
+        if ldap_base_dn is not None and not ldap_base_dn == config_base_dn:
+            base_dn = ldap_base_dn
+        else:
+            base_dn = config_base_dn
+
+        log.debug(_l("Synchronization is searching against base DN: %s") % (base_dn), level=8)
 
         if callback is None:
             callback = self._synchronize_callback
@@ -2398,7 +2429,14 @@
         self._bind()
 
         entry_dn = self.entry_dn(entry_id)
-        base_dn = self._base_dn()
+
+        config_base_dn = self.config_get('base_dn')
+        ldap_base_dn = self._kolab_domain_root_dn(self.domain)
+
+        if ldap_base_dn is not None and not ldap_base_dn == config_base_dn:
+            base_dn = ldap_base_dn
+        else:
+            base_dn = config_base_dn
 
         for _type in 'user', 'group', 'sharedfolder':
             __filter = self.config_get('kolab_%s_filter' % (_type))
@@ -2424,14 +2462,14 @@
 
         return None
 
-    def _find_user_dn(self, login, kolabuser=False, domain=None):
+    def _find_user_dn(self, login, kolabuser=False):
         """
             Find the distinguished name (DN) for a (Kolab) user entry in LDAP.
         """
 
         conf_prefix = 'kolab_' if kolabuser else ''
 
-        user_base_dn = self._object_base_dn('user', conf_prefix, domain)
+        user_base_dn = self._object_base_dn('user', conf_prefix)
 
         auth_attrs = self.config_get_list('auth_attributes')
 
@@ -2644,12 +2682,18 @@
 
         return domains
 
-    def _object_base_dn(self, objectType, prefix='', domain=None):
+    def _object_base_dn(self, objectType, prefix=''):
         """
            Get configured base DN for specified Kolab object type
         """
-        object_base_dn = self.config_get_raw(prefix + objectType + '_base_dn')
-        base_dn = self._base_dn(domain)
+        object_base_dn = self.config_get(prefix + objectType + '_base_dn')
+        config_base_dn = self.config_get('base_dn')
+        ldap_base_dn = self._kolab_domain_root_dn(self.domain)
+
+        if ldap_base_dn is not None and not ldap_base_dn == config_base_dn:
+            base_dn = ldap_base_dn
+        else:
+            base_dn = config_base_dn
 
         if object_base_dn is None:
             object_base_dn = base_dn
@@ -2658,15 +2702,6 @@
 
         return object_base_dn
 
-    def _base_dn(self, domain=None):
-        config_base_dn = self.config_get('base_dn')
-        ldap_base_dn = self._kolab_domain_root_dn(domain if domain is not None else self.domain)
-
-        if ldap_base_dn is not None and not ldap_base_dn == config_base_dn:
-            return ldap_base_dn
-
-        return config_base_dn
-
     def _synchronize_callback(self, *args, **kw):
         """
            Determine the characteristics of the callback being placed, and
@@ -2809,7 +2844,7 @@
         attrlist=None,
         attrsonly=0,
         timeout=-1,
-        callback=None,
+        callback=False,
         primary_domain=None,
         secondary_domains=
     ):
@@ -2825,8 +2860,6 @@
             )
         )
 
-        log.debug(_l("Searching with filter %r in %s") % (filterstr, base_dn), level=8)
-
         _search = self.ldap.search_ext(
             base_dn,
             scope=scope,
@@ -2905,7 +2938,7 @@
         attrlist=None,
         attrsonly=0,
         timeout=-1,
-        callback=None,
+        callback=False,
         primary_domain=None,
         secondary_domains=
     ):
@@ -2915,8 +2948,6 @@
 
         server_page_control = ldap.controls.libldap.SimplePagedResultsControl(size=page_size,cookie='')
 
-        log.debug(_l("Searching for %r in %s") % (filterstr, base_dn), level=8)
-
         _search = self.ldap.search_ext(
             base_dn,
             scope=scope,
@@ -2994,7 +3025,7 @@
         attrlist=None,
         attrsonly=0,
         timeout=-1,
-        callback=None,
+        callback=False,
         primary_domain=None,
         secondary_domains=
     ):
@@ -3008,7 +3039,7 @@
         attrlist=None,
         attrsonly=0,
         timeout=-1,
-        callback=None,
+        callback=False,
         primary_domain=None,
         secondary_domains=
     ):
@@ -3054,7 +3085,7 @@
         attrlist=None,
         attrsonly=0,
         timeout=None,
-        callback=None,
+        callback=False,
         primary_domain=None,
         secondary_domains=
     ):
@@ -3062,7 +3093,7 @@
         if timeout is None:
             timeout = float(self.config_get('ldap', 'timeout', default=10))
 
-        log.debug(_l("Searching for %r in %s") % (filterstr, base_dn), level=8)
+        log.debug(_l("Searching with filter %r") % (filterstr), level=8)
 
         _search = self.ldap.search(
             base_dn,
@@ -3092,8 +3123,8 @@
         attrlist=None,
         attrsonly=0,
         timeout=None,
-        override_search=None,
-        callback=None,
+        override_search=False,
+        callback=False,
         primary_domain=None,
         secondary_domains=
     ):
@@ -3150,7 +3181,7 @@
 
         _results = 
 
-        if override_search:
+        if override_search is not False:
             _use_ldap_controls = override_search
         else:
             _use_ldap_controls = self.ldap.supported_controls

pykolab-0.9.0.tar.gz/pykolab/cli/cmd_list_deleted_mailboxes.py Changed

pykolab-0.9.0.tar.gz/pykolab/imap/cyrus.py Changed

@@ -201,14 +201,13 @@
                 )
 
         # TODO: Workaround for undelete
-        if 'hex_timestamp' in _mailfolder:
-            mailfolder = "DELETED/%s%s%s@%s" % (
+        if len(self.lm(mailfolder)) < 1 and 'hex_timestamp' in _mailfolder:
+            mailfolder = self.folder_utf7("DELETED/%s%s%s@%s" % (
                     self.separator.join(_mailfolder'path_parts'),
                     self.separator,
                     _mailfolder'hex_timestamp',
                     _mailfolder'domain')
-
-        mailfolder = self.folder_utf7(mailfolder)
+               )
 
         # TODO: Murder capabilities may have been suppressed using Cyrus IMAP
         # configuration.
@@ -242,15 +241,18 @@
         max_tries = 20
         num_try = 0
 
-        ann_path = b"/vendor/cmu/cyrus-imapd/server"
-        s_ann_path = b"/shared%s" % (ann_path)
+        ann_path = "/vendor/cmu/cyrus-imapd/server"
+        s_ann_path = "/shared%s" % (ann_path)
 
         while 1:
             num_try += 1
-            annotations = self._getmetadata(mailfolder, ann_path)
+            annotations = self._getmetadata(
+                    '"%s"' % (mailfolder),
+                    ann_path
+                )
 
             if mailfolder in annotations:
-                if s_ann_path.encode('utf-8') in annotationsmailfolder:
+                if s_ann_path in annotationsmailfolder:
                     break
 
             if max_tries <= num_try:
@@ -277,7 +279,7 @@
 
             time.sleep(1)
 
-        server = annotationsmailfolders_ann_path.encode('utf-8')
+        server = annotationsmailfolders_ann_path
         self.mboxmailfolder = server
 
         log.debug(
@@ -452,11 +454,6 @@
 
         for undelete_folder in undelete_folders:
             undelete_mbox = self.parse_mailfolder(undelete_folder)
-            if undelete_mbox is None:
-                print(_("The folder to undelete does not exist") % (
-                            undelete_mbox
-                        ), file=sys.stdout)
-                return
 
             prefix = undelete_mbox'path_parts'.pop(0)
             mbox = undelete_mbox'path_parts'.pop(0)
@@ -502,12 +499,8 @@
                         )
                 )
 
+            target_server = self.find_mailfolder_server(target_folder)
             source_server = self.find_mailfolder_server(undelete_folder)
-            try:
-                target_server = self.find_mailfolder_server(target_folder)
-            except cyruslib.CYRUSError as errmsg:
-                # This is normal for a toplevel folder, the target does not exist
-                target_server = source_server
 
             if hasattr(conf, 'dry_run') and not conf.dry_run:
                 undelete_folder = self.folder_utf7(undelete_folder)

pykolab-0.9.0.tar.gz/pykolab/utils.py Changed

pykolab-0.9.0.tar.gz/wallace/module_footer.py Changed

@@ -85,17 +85,16 @@
     if not os.path.isdir(mybasepath):
         os.makedirs(mybasepath)
 
-    for stage in 'incoming':
+    for stage in 'incoming', 'ACCEPT':
         if not os.path.isdir(os.path.join(mybasepath, stage)):
             os.makedirs(os.path.join(mybasepath, stage))
 
-    # FIXME: This section of the code is probably not needed since we do not ACCEPT the mail anymore
     if 'stage' in kw:
         log.debug(_("Issuing callback after processing to stage %s") % (kw'stage'), level=8)
         log.debug(_("Testing cb_action_%s()") % (kw'stage'), level=8)
         if hasattr(modules, 'cb_action_%s' % (kw'stage')):
             log.debug(_("Attempting to execute cb_action_%s()") % (kw'stage'), level=8)
-            exec('modules.cb_action_%s(%r, %r)' % (kw'stage','footer',filepath))
+            exec('modules.cb_action_%s(%r, %r)' % (kw'stage','optout',filepath))
             return
 
     log.debug(_("Executing module footer for %r, %r") % (args, kw), level=8)
@@ -113,8 +112,8 @@
     footer = {}
 
     footer_position = conf.get('wallace', 'footer_position')
-    footer_html_file = conf.get('wallace', 'footer_html') or ''
-    footer_text_file = conf.get('wallace', 'footer_text') or ''
+    footer_html_file = conf.get('wallace', 'footer_html')
+    footer_text_file = conf.get('wallace', 'footer_text')
     sender_exceptions = conf.get('wallace', 'footer_sender_exceptions')
 
     if sender_exceptions:
@@ -128,13 +127,15 @@
                 if item == 'NONE':
                     regex = '^<>$'
 
-                if re.search(regex, sender, re.IGNORECASE):
-                    log.debug("Sender matches %s, pass along" % (item), level=8)
-                    return filepath
+                if re.search(regex, sender):
+                    log.debug("Sender matches exception %s" % (item), level=8)
+                    exec('modules.cb_action_%s(%r, %r)' % ('ACCEPT','footer', filepath))
+                    return
 
     if not os.path.isfile(footer_text_file) and not os.path.isfile(footer_html_file):
-        log.warning(_("No contents configured for footer module, pass along"))
-        return filepath
+        log.warning(_("No contents configured for footer module"))
+        exec('modules.cb_action_%s(%r, %r)' % ('ACCEPT','footer', filepath))
+        return
 
     if os.path.isfile(footer_text_file):
         footer'plain' = open(footer_text_file, 'r').read()
@@ -147,7 +148,8 @@
             footer'html' = '<p>' + footer'plain' + '</p>'
 
     if footer'plain' == "" and footer'html' == "<p></p>":
-        return filepath
+        exec('modules.cb_action_%s(%r, %r)' % ('ACCEPT','footer', filepath))
+        return
 
     footer_added = False
 
@@ -157,7 +159,8 @@
         pass
 
     if _footer_added == "YES":
-        return filepath
+        exec('modules.cb_action_%s(%r, %r)' % ('ACCEPT','footer', filepath))
+        return
 
     for part in message.walk():
         disposition = None
@@ -188,15 +191,12 @@
             footer_added = set_part_content(part, content)
 
     if footer_added:
+        log.debug("Footer attached.")
         message.add_header("X-Wallace-Footer", "YES")
 
-        (fp, new_filepath) = tempfile.mkstemp(dir="/var/spool/pykolab/wallace/footer/incoming")
+    (fp, new_filepath) = tempfile.mkstemp(dir="/var/spool/pykolab/wallace/footer/ACCEPT")
+    os.write(fp, message.as_string())
+    os.close(fp)
+    os.unlink(filepath)
 
-        log.debug("Footer attached, saving mail to %s and passing along" % (new_filepath), level=8)
-
-        os.write(fp, message.as_string())
-        os.close(fp)
-        os.unlink(filepath)
-        filepath = new_filepath
-
-    return filepath
+    exec('modules.cb_action_%s(%r, %r)' % ('ACCEPT','footer', new_filepath))

pykolab-0.9.0.tar.gz/wallace/module_invitationpolicy.py Changed

pykolab-0.9.0.tar.gz/wallace/modules.py Changed

pykolab.dsc Changed

release.sh Changed

Overview

Request 3208 (superseded)

Request History